You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently default internal logging level is Info, meaning that all log messages with Info, Warn, Error levels go to user's output by default. It doesn't look rational when we speak about the library should be silent as possible.
Warning and Errors are OK to be revealed by default, meaning "hey dear user, please pay attention". But it doesn't make sense for Info level. Now it is clear why Selenium has no Info messages at all.
• Reduce default console output from the library
• Make library less verbose by default
Requires further human verification:
• Verify that warnings and errors are still appropriately visible to users
• Test that this change doesn't break existing applications that rely on Info level logs
• Confirm that users can still enable Info level logging when needed
Changing the default log level from Info to Warn could be a breaking change for applications that depend on Info level messages being visible by default. This should be documented and considered for version compatibility.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Currently default internal logging level is
Info, meaning that all log messages withInfo,Warn,Errorlevels go to user's output by default. It doesn't look rational when we speak about the library should be silent as possible.Warning and Errors are OK to be revealed by default, meaning "hey dear user, please pay attention". But it doesn't make sense for
Infolevel. Now it is clear why Selenium has no Info messages at all.🔗 Related Issues
Contributes to #15785
💥 What does this PR do?
Change default internal logging level.
🔄 Types of changes
PR Type
Other
Description
Change default internal log level from Info to Warn
Reduce verbosity of library output by default
Keep warnings and errors visible to users
Diagram Walkthrough
File Walkthrough
LogContextManager.cs
Update default log level configurationdotnet/src/webdriver/Internal/Logging/LogContextManager.cs
instead of LogEventLevel.Info